X-Git-Url: http://g0dil.de/git?a=blobdiff_plain;f=Packets%2FPacketType.ct;h=caec158fa3db3634b31bf79116ba943b303e43b8;hb=3863d46dd898b7bc35ea8c6ccd8563b18762a6b6;hp=5443c1db106c5dff4480216a6b7089b244081914;hpb=3a1b45cae9d48b1d53fc310e2a283d2b9d17275e;p=senf.git diff --git a/Packets/PacketType.ct b/Packets/PacketType.ct index 5443c1d..caec158 100644 --- a/Packets/PacketType.ct +++ b/Packets/PacketType.ct @@ -1,6 +1,6 @@ // $Id$ // -// Copyright (C) 2008 +// Copyright (C) 2008 // Fraunhofer Institute for Open Communication Systems (FOKUS) // Competence Center NETwork research (NET), St. Augustin, GERMANY // Stefan Bund @@ -35,17 +35,19 @@ template prefix_ senf::PacketInterpreterBase::optional_range -senf::PacketTypeMixin::nextPacketRange(Packet p) +senf::PacketTypeMixin::nextPacketRange(Packet const & p) { - if (p.data().size() < Self::initSize()) - return PacketTypeBase::no_range(); typename Self::size_type sz (Self::initHeadSize()); ///\idea This if condition could be replaced with a compile time switch by checking, wether /// (the function address) Self::initHeadSize is different from PacketTypeBase::initHeadSize - if (sz == PacketTypeBase::size_type(-1)) - return PacketTypeBase::range(boost::next(p.data().begin(), - bytes(p.as< ConcretePacket >().parser())), - p.data().end()); + if (sz == PacketTypeBase::size_type(-1)) { + typename Self::size_type headsz (bytes(p.as< ConcretePacket >().parser())); + return p.data().size() < headsz ? + PacketTypeBase::no_range() : + PacketInterpreterBase::optional_range( + PacketTypeBase::range(boost::next(p.data().begin(), headsz), + p.data().end())); + } else // If we have a trailer, we do *not* use the 'bytes' value but initSize/initHeadSize, this // is much safer since the bytes() value will probably not be very correct anyways (what @@ -53,8 +55,11 @@ senf::PacketTypeMixin::nextPacketRange(Packet p) // or the size of the packet from header to trailer including payload?). // // So, the helper only works with fixed-size parsers if the packet has a trailer. - return PacketTypeBase::range(boost::next(p.data().begin(),sz), - boost::prior(p.data().end(),Self::initSize()-sz)); + return p.data().size() < Self::initSize() ? + PacketTypeBase::no_range() : + PacketInterpreterBase::optional_range( + PacketTypeBase::range(boost::next(p.data().begin(),sz), + boost::prior(p.data().end(),Self::initSize()-sz))); } ///////////////////////////////ct.e////////////////////////////////////////