X-Git-Url: http://g0dil.de/git?a=blobdiff_plain;f=Scheduler%2FWriteHelper.ct;h=758d8b55a64c6a028ceb9ba102480ee987add6ff;hb=81ffa1c459b96dd44472bcef37e1e373934ee138;hp=28bf5b6d2caf6e984d5b047476a106c86b1ce10b;hpb=553781d9e9bce316dca24ac4f0c42e5613e849e0;p=senf.git

diff --git a/Scheduler/WriteHelper.ct b/Scheduler/WriteHelper.ct
index 28bf5b6..758d8b5 100644
--- a/Scheduler/WriteHelper.ct
+++ b/Scheduler/WriteHelper.ct
@@ -16,7 +16,7 @@
 // along with this program; if not, write to the
 // Free Software Foundation, Inc.,
 // 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
-// Copyright (C) 2006 
+// Copyright (C) 2006
 
 /** \file
     \brief WriteHelper non-inline template implementation */
@@ -32,23 +32,23 @@
 ///////////////////////////////ct.p////////////////////////////////////////
 
 template <class Handle>
-prefix_ senf::WriteHelper<Handle>::WriteHelper(Handle handle, std::string data,
+prefix_ senf::WriteHelper<Handle>::WriteHelper(Handle handle, std::string const & data,
                                                       Callback callback)
     : handle_(handle), data_(data), callback_(callback),
-      offset_(0), errno_(0)
+      offset_(data_.begin()), errno_(0)
 {
     senf::Scheduler::instance()
-	.add(handle_, boost::bind(&WriteHelper::dispatchProcess, ptr(this), _1, _2),
-	     senf::Scheduler::EV_WRITE);
+        .add(handle_, boost::bind(&WriteHelper::dispatchProcess, ptr(this), _1, _2),
+             senf::Scheduler::EV_WRITE);
 }
 
 template <class Handle>
 prefix_ std::string const & senf::WriteHelper<Handle>::data()
     const
 {
-    if (offset_ > 0) {
-	data_.erase(0,offset_);
-	offset_ = 0;
+    if (offset_ > data_.begin()) {
+        data_.erase(data_.begin(),offset_);
+        offset_ = data_.begin();
     }
     return data_;
 }
@@ -58,7 +58,7 @@ prefix_ void senf::WriteHelper<Handle>::revoke()
 {
     ptr guard (this); // To ensure, 'this' is deleted only after this method terminates ...
     senf::Scheduler::instance()
-	.remove(handle_, senf::Scheduler::EV_WRITE);
+        .remove(handle_, senf::Scheduler::EV_WRITE);
 }
 
 template <class Handle>
@@ -75,20 +75,24 @@ template <class Handle>
 prefix_ void senf::WriteHelper<Handle>::process(Handle handle,
                                                        senf::Scheduler::EventId event)
 {
-    /** \fixme Move the done() calls to outside the try/catch block */
+    bool complete_ (false);
     try {
-	if (event != senf::Scheduler::EV_WRITE)
-	    throw senf::SystemException(EPIPE);
-	offset_ += handle.write(data_.data()+offset_,data_.size()-offset_);
-	if (offset_ >= data_.size()) {
-	    data_.erase();
-	    done();
-	}
+        if (event != senf::Scheduler::EV_WRITE)
+            throw senf::SystemException(EPIPE);
+        offset_ = handle.write(std::make_pair(offset_,data_.end()));
+        if (offset_ == data_.end()) {
+            data_.erase();
+            offset_ = data_.begin();
+            complete_ = true;
+        }
     }
     catch (senf::SystemException const & ex) {
-	errno_ = ex.err;
-	done();
+        errno_ = ex.err;
+        done();
+        return;
     }
+    if (complete_)
+        done();
 }
 
 template <class Handle>
@@ -104,4 +108,10 @@ prefix_ void senf::WriteHelper<Handle>::done()
 
 // Local Variables:
 // mode: c++
+// fill-column: 100
+// c-file-style: "senf"
+// indent-tabs-mode: nil
+// ispell-local-dictionary: "american"
+// compile-command: "scons -u test"
+// comment-column: 40
 // End: