X-Git-Url: http://g0dil.de/git?a=blobdiff_plain;f=senf%2FScheduler%2FFIFORunner.cc;h=94009c32e9de87e06f90bfa1ae9c780e3323ba04;hb=78a6e233083efa63a9cd0684a92abc64202a9ee7;hp=ec9355916fb7b26371b14e1acbfb886e9149d187;hpb=42993f284009a951b77718ece3e7a2747041c566;p=senf.git

diff --git a/senf/Scheduler/FIFORunner.cc b/senf/Scheduler/FIFORunner.cc
index ec93559..94009c3 100644
--- a/senf/Scheduler/FIFORunner.cc
+++ b/senf/Scheduler/FIFORunner.cc
@@ -29,16 +29,16 @@
 // Custom includes
 #include <signal.h>
 #include <time.h>
-#include <boost/lambda/lambda.hpp>
+#include <cassert>
 #include <senf/Utils/Exception.hh>
 #include <senf/Utils/senfassert.hh>
-#include <senf/Utils/ScopeExit.hh>
 #ifdef SENF_DEBUG
-	#include <execinfo.h>
+    #include <execinfo.h>
 #endif
 #include <senf/config.hh>
 #include <stdint.h>
 #include <stdio.h>
+#include "senf/Utils/IgnoreValue.hh"
 
 //#include "FIFORunner.mpp"
 #define prefix_
@@ -113,7 +113,7 @@ prefix_ void senf::scheduler::detail::FIFORunner::stopWatchdog()
 // At the moment, the FIFORunner is not very efficient with many non-runnable tasks since the
 // complete list of tasks is traversed on each run().
 //
-// To optimize this, we woould need a way to find the relative ordering of two tasks in O(1) (at the
+// To optimize this, we would need a way to find the relative ordering of two tasks in O(1) (at the
 // moment, this is an O(N) operation by traversing the list).
 //
 // One idea is, to give each task an 'order' value. Whenever a task is added at the end, it's order
@@ -191,31 +191,37 @@ prefix_ void senf::scheduler::detail::FIFORunner::run(TaskList::iterator f, Task
     TaskList::iterator end (TaskList::current(null));
     next_ = f;
 
-    using namespace boost::lambda;
-    ScopeExit atExit ((
-                          var(watchdogCount_) = 0,
-                          var(next_) = l
-                     ));
-
-    while (next_ != end) {
-        TaskInfo & task (*next_);
-        if (task.runnable_) {
-            task.runnable_ = false;
-            runningName_ = task.name();
-#       ifdef SENF_DEBUG
-            runningBacktrace_ = task.backtrace_;
-#       endif
-            TaskList::iterator i (next_);
-            ++ next_;
-            tasks_.splice(l, tasks_, i);
-            watchdogCount_ = 1;
-            yield_ = false;
-            task.run();
-            if (yield_)
-                return;
+    // Would prefer to use ScopeExit+boost::lambda here instead of try but profiling has shown that
+    // to be to costly here
+
+    try {
+        while (next_ != end) {
+            TaskInfo & task (*next_);
+            if (task.runnable_) {
+                task.runnable_ = false;
+                runningName_ = task.name();
+    #       ifdef SENF_DEBUG
+                runningBacktrace_ = task.backtrace_;
+    #       endif
+                TaskList::iterator i (next_);
+                ++ next_;
+                tasks_.splice(l, tasks_, i);
+                watchdogCount_ = 1;
+                yield_ = false;
+                task.run();
+                if (yield_)
+                    return;
+            }
+            else
+                ++ next_;
         }
-        else
-            ++ next_;
+        watchdogCount_ = 0;
+        next_ = l;
+    }
+    catch (...) {
+        watchdogCount_ = 0;
+        next_ = l;
+        throw;
     }
 }
 
@@ -223,11 +229,11 @@ prefix_ senf::scheduler::detail::FIFORunner::TaskList::iterator
 senf::scheduler::detail::FIFORunner::priorityEnd(TaskInfo::Priority p)
 {
     switch (p) {
-    case senf::scheduler::detail::FIFORunner::TaskInfo::PRIORITY_LOW :
+    case TaskInfo::PRIORITY_LOW :
         return tasks_.end();
-    case senf::scheduler::detail::FIFORunner::TaskInfo::PRIORITY_NORMAL :
+    case TaskInfo::PRIORITY_NORMAL :
         return TaskList::current(normalPriorityEnd_);
-    case senf::scheduler::detail::FIFORunner::TaskInfo::PRIORITY_HIGH :
+    case TaskInfo::PRIORITY_HIGH :
         return TaskList::current(highPriorityEnd_);
     }
     return tasks_.begin();
@@ -252,32 +258,32 @@ prefix_ void senf::scheduler::detail::FIFORunner::watchdogError()
     static void * entries[SENF_DEBUG_BACKTRACE_NUMCALLERS];
 
     // We don't care if the write commands below fail, we just give our best to inform the user
-    (void) write(1, "\n\n*** Scheduler task hanging (pid ",34);
+    senf::IGNORE( write(1, "\n\n*** Scheduler task hanging (pid ",34) );
     static char pid[7];
     ::snprintf(pid, 7, "%6d", ::getpid());
     pid[6] = 0;
-    (void) write(1, pid, 6);
-    (void) write(1, "): ", 3);
-    (void) write(1, runningName_.c_str(), runningName_.size());
-    (void) write(1, " at\n ", 3);
+    senf::IGNORE( write(1, pid, 6) );
+    senf::IGNORE( write(1, "): ", 3) );
+    senf::IGNORE( write(1, runningName_.c_str(), runningName_.size()) );
+    senf::IGNORE( write(1, " at\n ", 3) );
 #ifdef SENF_DEBUG
     unsigned nEntries( ::backtrace(entries, SENF_DEBUG_BACKTRACE_NUMCALLERS) );
     for (unsigned i (0); i < nEntries; ++i) {
-        write(1, " 0x", 3);
+        senf::IGNORE( write(1, " 0x", 3) );
         for (unsigned j (sizeof(void*)); j > 0; --j) {
             uintptr_t v ( reinterpret_cast<uintptr_t>(entries[i]) >> (8*(j-1)) );
-            (void) write(1, &(hex[ (v >> 4) & 0x0f ]), 1);
-            (void) write(1, &(hex[ (v     ) & 0x0f ]), 1);
+            senf::IGNORE( write(1, &(hex[ (v >> 4) & 0x0f ]), 1) );
+            senf::IGNORE( write(1, &(hex[ (v     ) & 0x0f ]), 1) );
         }
     }
 #endif
-    (void) write(1, "\n", 1);
+    senf::IGNORE( write(1, "\n", 1) );
 
 #ifdef SENF_DEBUG
-    (void) write(1, "Task was initialized at\n", 24);
-    (void) write(1, runningBacktrace_.c_str(), runningBacktrace_.size());
+    senf::IGNORE( write(1, "Task was initialized at\n", 24) );
+    senf::IGNORE( write(1, runningBacktrace_.c_str(), runningBacktrace_.size()) );
 #endif
-    (void) write(1, "\n", 1);
+    senf::IGNORE( write(1, "\n", 1) );
     if (watchdogAbort_)
         assert(false);
 }